> diff --git a/attr.c b/attr.c
> index 42ad6de8c7..99883024ec 100644
> --- a/attr.c
> +++ b/attr.c
> @@ -11,8 +11,13 @@
> #include "exec-cmd.h"
> #include "attr.h"
> #include "dir.h"
> +#include "git-compat-util.h"
Unneeded. cf. Documentation/CodingGuidelines
- The first #include in C files, except in platform specific compat/
implementations, must be either "git-compat-util.h", "cache.h" or
"builtin.h". You do not have to include more than one of these.
and this file already begins with including "cache.h".
By the way,
$ make
$ cd t
$ sh t0003-attributes.sh -i -x
Initialized empty Git repository in /home/gitster/w/git.git/t/trash directory.t0003-attributes/.git/
expecting success of 0003.1 'open-quoted pathname':
echo "\"a test=a" >.gitattributes &&
attr_check a unspecified
++ echo '"a test=a'
++ attr_check a unspecified
++ attr_check_basic a unspecified
++ path=a
++ expect=unspecified
++ git_opts=
++ git check-attr test -- a
t0003-attributes.sh: line 9: 1508946 Segmentation fault git $git_opts check-attr test -- "$path" > actual 2> err
error: last command exited with $?=139
not ok 1 - open-quoted pathname
#
# echo "\"a test=a" >.gitattributes &&
# attr_check a unspecified
#
1..1
$ exit
there seems to be something fishy in this patch.
