On 12/7/2022 1:59 PM, Eric Sunshine wrote: > On Wed, Dec 7, 2022 at 12:27 PM Derrick Stolee via GitGitGadget > <gitgitgadget@xxxxxxxxx> wrote: >> +If you enable `index.skipHash`, then older Git clients may report that >> +your index is corrupt during `git fsck`. > > This documentation is rather minimal. Given this description, are > readers going to understand the purpose of the option, when they > should use it, what the impact will be, when and why they should avoid > it, etc.? I will expand this with explicit version numbers for older Git versions. >> diff --git a/t/t1600-index.sh b/t/t1600-index.sh >> @@ -65,6 +65,14 @@ test_expect_success 'out of bounds index.version issues warning' ' >> +test_expect_success 'index.skipHash config option' ' >> + ( >> + rm -f .git/index && >> + git -c index.skipHash=true add a && >> + git fsck >> + ) >> +' > > What is the purpose of the subshell here? I was matching the style of the nearby tests, but they are all modifying GIT_INDEX_VERSION, which isn't necessary here. Thanks, -Stolee
