On Wed, Nov 30 2022, Junio C Hamano wrote:
> Sergey Organov <sorganov@xxxxxxxxx> writes:
>
>> Junio C Hamano <gitster@xxxxxxxxx> writes:
>>
>>> Sergey Organov <sorganov@xxxxxxxxx> writes:
>>>
>>>> + if (set_func != NULL) {
>>>
>>> Please write it like so:
>>>
>>> if (set_func) {
>>
>> OK, will do.
>>
>>>
>>> I am not reviewing any new feature topic during -rc period (yet),
>>> but this triggered CI failure at the tip of 'seen', so.
>>
>> Thanks! Do we now have tool for auto-check for these issues? I still use
>> one from Linux kernel, and it didn't object to this form.
>
> I noticed it when I pushed to GitHub, which ran the CI ;-)
>
> If you have your own fork at GitHub of https://github.com/git/git/, I
> think preparing a pull request against it triggers the CI.
...in this case though there's no reason to wait for the glacially slow
GitHub CI. You just need spatch installed and:
make coccicheck
Sergey: If you've hacked on the (I'm assuming linux) kernel you likely
have that installed already, they use it too (being the canonical and I
believe original use-case for it).
