Re: [PATCH 3/5] diff-merges: implement log.diffMergesForce config

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 3/5] diff-merges: implement log.diffMergesForce config
From: Junio C Hamano <gitster@xxxxxxxxx>
Date: Mon, 28 Nov 2022 11:35:12 +0900
Cc: Jeff King <peff@xxxxxxxx>, Philip Oakley <philipoakley@iee.email>, Elijah Newren <newren@xxxxxxxxx>, Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx>, Alex Henrie <alexhenrie24@xxxxxxxxx>, Jonathan Nieder <jrnieder@xxxxxxxxx>, huang guanlong <gl041188@xxxxxxxxx>, git@xxxxxxxxxxxxxxx
In-reply-to: <20221127093721.31012-4-sorganov@gmail.com> (Sergey Organov's message of "Sun, 27 Nov 2022 12:37:19 +0300")
References: <20221127093721.31012-1-sorganov@gmail.com> <20221127093721.31012-4-sorganov@gmail.com>
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.1 (gnu/linux)

Sergey Organov <sorganov@xxxxxxxxx> writes:

> +	if (set_func != NULL) {

Please write it like so:

	if (set_func) {

I am not reviewing any new feature topic during -rc period (yet),
but this triggered CI failure at the tip of 'seen', so.

Follow-Ups:
- Re: [PATCH 3/5] diff-merges: implement log.diffMergesForce config
  - From: Sergey Organov

References:
- [PATCH 0/5] diff-merges: more features
  - From: Sergey Organov
- [PATCH 3/5] diff-merges: implement log.diffMergesForce config
  - From: Sergey Organov

Prev by Date: Re: [PATCH v4 4/4] ci: install python on ubuntu
Next by Date: Re: [PATCH v1 2/4] t1301: use test_when_finished for cleanup
Previous by thread: [PATCH 3/5] diff-merges: implement log.diffMergesForce config
Next by thread: Re: [PATCH 3/5] diff-merges: implement log.diffMergesForce config
Index(es):
- Date
- Thread

[Index of Archives] [Linux Kernel Development] [Gcc Help] [IETF Annouce] [DCCP] [Netdev] [Networking] [Security] [V4L] [Bugtraq] [Yosemite] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux SCSI] [Fedora Users]

Powered by Linux