Philip Oakley <philipoakley@iee.email> writes: > Ping, Hopefully an easy single patch review for someone on-list. > > Potential review points: > > Is the commit message sufficient? > Are the tests: Sufficient, Complete, Correct ? > Is `qz_to_tab_space` conversion applied correctly? Is the feature and the design sensible? Are the tests checking interesting cases? The underlying mechanism uses strbuf_utf8_replace() because there are character strings whose display columns do not match their byte length (otherwise you can just use strlen() and chomp at byte boundary), so a test whose result would be different if strbuf_utf8_replace() were replaced with a more naive strbuf_splice() would be valuable and meaningful.
