Looking for a review (pretty-formats, hard truncation), was What's cooking in git.git (Nov 2022, #04; Fri, 18))

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Ping, Hopefully an easy single patch review for someone on-list.

Patch [v4] itself:
https://lore.kernel.org/git/20221112143616.1429-1-philipoakley@iee.email/

Available at: https://github.com/ttaylorr/git/tree/po/pretty-hard-trunc

On 19/11/2022 02:22, Taylor Blau wrote:
> --------------------------------------------------
> [Cooking]
>
> * po/pretty-hard-trunc (2022-11-13) 1 commit
>  - pretty-formats: add hard truncation, without ellipsis, options
>
>  Add a new pretty format which truncates without ellipsis.
>
>  Waiting for review.
>  source: <20221112143616.1429-1-philipoakley@iee.email>

Potential review points:

Is the commit message sufficient?
Are the tests: Sufficient,  Complete, Correct ?
Is `qz_to_tab_space` conversion applied correctly?

--
Philip



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux