On Sat, Oct 22, 2022 at 07:19:21PM -0400, Michael McClimon wrote: > > I prepared it on top of your fix in the mm/git-pm-try-catch-syntax-fix > > branch. That's not strictly necessary, since my patch deletes the line > > you fixed. :) But I think it's nicer to use your fix as the starting > > point, since it means the test runs but produces the wrong behavior, > > rather than barfing with a syntax error. > > My vanity thanks you for this, even if it's not strictly necessary. As a > professional programmer with roughly no C chops and a long-time admirer of the > Git project, all I _really_ wanted to do was to fix a thing that was in my > wheelhouse so that I could say I have a commit in the history. (This isn't a > good reason on its own, of course, but I'm happy it was useful even if the > line is immediately deleted!) :) I think it makes my patch easier to understand, but I'm glad you are getting some you, too. Finding the original issue and the ensuing discussion was as much (or more) effort than the actual fix. Thanks for starting it! -Peff
