On Wed, Oct 05 2022, Jeff King wrote: > On Mon, Oct 03, 2022 at 07:45:44PM -0400, Alejandro R. Sedeño wrote: > >> I'm targeting an old SunOS 5.10 with a GCC 3.4.3, for reasons that can >> only be described as self-loathing. :-) >> The other users of GIT_GNUC_PREREQ are used for 2.8, and 3.1, so I >> figure distinguishing between 4.5+ and <4.5 should be well supported. >> >> Regardless, there's no reason to break older compilers over something >> that's this trivial to fix. > > This will cause some mild hardships, as later patches will need to > #define UNUSED in other spots, as well, in order to get full coverage of > the code base (I have written those annotation patches, but they're not > applied upstream yet). Sorry about any trouble in having to rebase those on UNUSED. If you're taking requests it would be really useful to prioritize changes to shared headers and the like, e.g. DEVOPTS=extra-all on pretty much any file will start with: git-compat-util.h: In function ‘precompose_argv_prefix’: git-compat-util.h:313:54: error: unused parameter ‘argc’ [-Werror=unused-parameter] 313 | static inline const char *precompose_argv_prefix(int argc, const char **argv, const char *prefix) | ~~~~^~~~ git-compat-util.h:313:73: error: unused parameter ‘argv’ [-Werror=unused-parameter] 313 | static inline const char *precompose_argv_prefix(int argc, const char **argv, const char *prefix) | ~~~~~~~~~~~~~^~~~ git-compat-util.h: In function ‘git_has_dos_drive_prefix’: git-compat-util.h:423:56: error: unused parameter ‘path’ [-Werror=unused-parameter] 423 | static inline int git_has_dos_drive_prefix(const char *path) | ~~~~~~~~~~~~^~~~ git-compat-util.h: In function ‘git_skip_dos_drive_prefix’: git-compat-util.h:431:52: error: unused parameter ‘path’ [-Werror=unused-parameter] 431 | static inline int git_skip_dos_drive_prefix(char **path)
