On Mon, Oct 03, 2022 at 10:29:24AM +0100, Phillip Wood wrote: > > The bug goes back to 442c36bd08 (am: improve author-script error > > reporting, 2018-10-31), though the code was soon after moved to this > > spot by bcd33ec25f (add read_author_script() to libgit, 2018-10-31). > > It was presmably just a typo in 442c36bd08. > > s/presmbly/presumably/ Yep. > > We'll add test coverage for all the error cases here, though only the > > GIT_AUTHOR_NAME ones fail (even in a vanilla build they to segfault > > Do you mean "they ought to segfault"? I think it's just s/to//. I.e., "even in a vanilla build they segfault consistently". I rewrote that sentence a few times trying to make it as not-confusing as possible, but managed to leave in an editing error anyway. ;) -Peff