On Thu, Sep 22, 2022 at 04:59:31PM +0000, Matthew John Cheetham via GitGitGadget wrote: > Whilst working in the credential helper and auth space I happened to notice > that the behaviour of some of the credential helpers in contrib/credential/ > is not consistent. > > Specifically both the git-credential-wincred and git-credential-netrc > helpers die when they receive unknown credential property keys, which is > contrary to the behaviour of all the other in-tree helpers including: > git-credential-cache, -store, -libsecret, -gnome-keyring, -osxkeychain. > > Also update the git-credential-osxkeychain helper to include a comment > making it's behaviour explicit in ignoring unknown keys, as per other > helpers. Thanks, I think these are all sensible changes. The new behavior matches the original vision of the helper protocol. But more importantly, it brings them in line with all of the _other_ existing helpers. Which is no coincidence, since the designer of the protocol wrote most of them. ;) I haven't had a chance to look carefully at the rest of your larger series yet, but I think these are a nice standalone improvement regardless of what happens there. -Peff
