On 9/22/2022 12:59 PM, Matthew John Cheetham via GitGitGadget wrote: > Whilst working in the credential helper and auth space I happened to notice > that the behaviour of some of the credential helpers in contrib/credential/ > is not consistent. > > Specifically both the git-credential-wincred and git-credential-netrc > helpers die when they receive unknown credential property keys, which is > contrary to the behaviour of all the other in-tree helpers including: > git-credential-cache, -store, -libsecret, -gnome-keyring, -osxkeychain. > > Also update the git-credential-osxkeychain helper to include a comment > making it's behaviour explicit in ignoring unknown keys, as per other > helpers. Thanks for sending this patches separate from your earlier RFC. I think these patches speak for themselves and are good to go. Thanks, -Stolee
