On Mon, Sep 12, 2022 at 04:55:01PM -0700, Junio C Hamano wrote:
> "Eric Sunshine via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
>
> > + $checked =~ s/(\?![^?]+\?!)/$c->{bold}$c->{red}$1$c->{reset}/mg;
>
> It may be just me, but coloring the whole "?!LOOP?!" in red feels a
> bit strange. I would have expected more like
>
> if ($c->{color_in_use}) {
> $checked =~ s/\?!([^?]+)\?!/$c->{bold}$c->{red}$1$c->{reset}/mg;
> }
>
> IOW, switching between "?!LOOP?!" and "<BOLD><RED>LOOP<RESET>".
>
> But it may be just me.
Having seen the output in the wild (or at least on the example which I
found hard to read originally), I kind of like the "?!" being retained
even in the color version. It really makes things stand out.
-Peff
