On Thu, Aug 18, 2022 at 12:01 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > On Thu, Aug 18 2022, Derrick Stolee wrote: > > +test_ancestry () { > > + args=$1 > > + expected=$2 > > Maybe add &&-chaining here (we do it in some cases, but I'm not sure > when such assignments would ever fail). Assignment shouldn't fail, but keeping the &&-chain intact here protects us against the unlikely event of someone inserting &&-chained code above these assignments and not realizing that the &&-chain is not intact at the assignment lines.