On 2022-08-18 at 14:00:30, Sergio via GitGitGadget wrote: > From: Sergio <sergeikrivonos@xxxxxxxxx> > > Signed-off-by: Sergio <sergeikrivonos@xxxxxxxxx> Typically you'll want to explain in the commit message why this is a valuable change. For example, I don't have this option set and don't use it, and I always stash my changes manually before rebasing. You should tell me why the user will benefit from this setting defaulting to enabled, since I personally don't see a need for it. You may also want to discuss why any pitfalls of stash, such as unadded changes being added after a stash pop, are not problematic here and why this behaviour won't be more surprising or annoying to experienced users who are used to seeing an error message instead. This isn't to say that the change is bad or we shouldn't accept it, only that I (and others) need help understanding why it's a good change to make. -- brian m. carlson (he/him or they/them) Toronto, Ontario, CA
Attachment:
signature.asc
Description: PGP signature
