On Fri, Jul 29, 2022 at 08:58:46AM -0400, Derrick Stolee wrote: > On 7/29/2022 8:28 AM, Johannes Schindelin via GitGitGadget wrote: > > Since 3a251bac0d1a (trace2: only include "fsync" events if we git_fsync(), > > 2022-07-18), the FreeBSD builds are failing in t5351.6. See > > https://cirrus-ci.com/task/4577761405698048 for an example. The run at > > https://cirrus-ci.com/task/6004115347079168 shows that this patch fixes the > > bug. > > Thanks for noticing and fixing this bug. The FreeBSD build is slow It usually takes a little more than 7 minutes for a full run, which is IMHO less (at least wall time) than the whole CI does; could you elaborate on why being "slow" would warrant ignoring its failures? > and flaky enough that I sometimes ignore its output before submitting > a series. Good that it will be green again. I'd noticed that because it runs outside GitHub actions it sometimes has synchronization(ex [1]) issues, but that might be some bug on the integration with Cirrus which is easily avoided by looking instead directly to their status page: https://cirrus-ci.com/github/git/git Carlo