On 7/29/2022 8:28 AM, Johannes Schindelin via GitGitGadget wrote: > Since 3a251bac0d1a (trace2: only include "fsync" events if we git_fsync(), > 2022-07-18), the FreeBSD builds are failing in t5351.6. See > https://cirrus-ci.com/task/4577761405698048 for an example. The run at > https://cirrus-ci.com/task/6004115347079168 shows that this patch fixes the > bug. Thanks for noticing and fixing this bug. The FreeBSD build is slow and flaky enough that I sometimes ignore its output before submitting a series. Good that it will be green again. > While verifying the fix on Windows, I noticed a recent, rather terrible > performance regression: t5351 all of a sudden takes almost half an hour > [https://github.com/git/git/runs/7398490747?check_suite_focus=true#step:5:171] > to run on Windows. I found a fix, and it now passes in less than half a > minute > [https://github.com/gitgitgadget/git/runs/7578071365?check_suite_focus=true#step:5:125] > again. Thanks for speeding this up! -Stolee
