On Mon, Jul 11, 2022 at 10:12:18PM +0200, Ævar Arnfjörð Bjarmason wrote: > > I was also somewhat confused by the double-assignment of "result" in the > > cleanup label. But I think that is because diff_result_code() is > > massaging the current value of "result" into the right thing. But in > > that case, should the "-1" from earlier be passed to diff_result_code()? > > I think probably not (and certainly it was not before your patch). Which > > would imply that the label should go after that, like: > [...] > > Urgh, yes that's the obviously correct fix to bring it back to the > previous behavior, it's indeed just a misplaced "cleanup" label, sorry > about that. Thanks, I'll work it up into a real patch. Which I should have just done in the first place; I just hadn't convinced myself I understood everything until I finished writing the other email. :) -Peff
