On 6/2/2022 10:13 AM, Ævar Arnfjörð Bjarmason wrote: > > On Thu, Jun 02 2022, Derrick Stolee wrote: > >> On 6/2/2022 5:05 AM, Johannes Schindelin via GitGitGadget wrote: >>> Note that the changes to the GitHub workflow are somewhat transient in >>> nature: Based on the feedback I received on the Git mailing list, I see some >>> appetite for turning Scalar into a full-fledged top-level command in Git, >>> similar to gitk. Therefore my current plan is to do exactly that in the end >>> (and I already have patches lined up to that end). This will essentially >>> revert the ci/run-build-and-tests.sh change in this patch series. >> >> I expect that this won't be a full remote, since we will still want to >> exclude Scalar from the build without INCLUDE_SCALAR enabled. > > "a full remote"? Whoops. My brain is mixed up with the work I've been doing in remote.c. I meant "a full revert". > Scalar (well, scalar.o, not scalar the binary) has been included in the > default build (including CI) for a while now. I'm talking about scalar the binary being important. I'm glad that scalar.o has been built already. > What we haven't been doing until this series it to link it with libgit.a > or running its tests. > > So perhaps that's what you mean, but in an earlier series it wasn't > building scalar.o, and I remember there being some confusion on this > point in the past, seemingly based on a mental model of the scalar > patches that pre-dated the re-roll that eventually got merged. Yes, it is important that we revisit these patches with the previous changes in mind. In particular, I don't see a single reference to INCLUDE_SCALAR in the tree at the 'next' branch. This is different from the build in the microsoft/git fork, which is where I've done all of my own Scalar development. Thanks, -Stolee
