On 6/2/2022 5:05 AM, Johannes Schindelin via GitGitGadget wrote: > During the review of the initial Scalar patch series, it was suggested to > include Scalar in Git's CI builds. Due to some conflicts, this was postponed > to a later patch series: This patch series. It's good to start running Scalar builds and tests during CI before moving from contrib/. We can establish a pattern that the code is not causing build failures, and demonstrate that the tests succeed consistently. Better to do that while still in the mode where we can easily reverse course. > Note that the changes to the GitHub workflow are somewhat transient in > nature: Based on the feedback I received on the Git mailing list, I see some > appetite for turning Scalar into a full-fledged top-level command in Git, > similar to gitk. Therefore my current plan is to do exactly that in the end > (and I already have patches lined up to that end). This will essentially > revert the ci/run-build-and-tests.sh change in this patch series. I expect that this won't be a full remote, since we will still want to exclude Scalar from the build without INCLUDE_SCALAR enabled. Thanks, -Stolee
