Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> writes: >> Scalar is not (yet?) a Git command. > > "test-tool" isn't "git" either, so I think this argument is a > non-starter. > > As the documentation for "test_must_fail" notes the distinction is > whether something is "system-supplied". I.e. we're not going to test > whether "grep" segfaults, but we should test our own code to see if it > segfaults. > > The scalar code is code we ship and test, so we should use the helper > that doesn't hide a segfault. > > I don't understand why you wouldn't think that's the obvious fix here, > adding "scalar" to that whitelist is a one-line fix, and clearly yields > a more useful end result than a test silently hiding segfaults. FWIW, I don't, either.
