Re: [PATCH] diffcore-rename: cache file deltas

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Tue, 25 Sep 2007, Junio C Hamano wrote:
> >
> >  - the name diff_free_filespec_data_large is horrible, but this is based
> >    on the fact that diff_free_filespec_data actually does too much (it
> >    frees the data _and_ some other auxiliary data). And renaming that
> >    would entail changing many callsites.
> 
> True.  But we can rename it to diff_file_filespec_blob() and
> that would perfectly well describe what it does.  Will do so
> when applying if it is Ok to you.

Well, that renaming apparently never happened, and it's still called 
diff_free_filespec_data_large() now that it's in master.

That said, I think this patch should make it into the maintenance branch 
too, renamed or not, since it's such a huge performance issue.

			Linus
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux