On Tue, Sep 25, 2007 at 02:29:07PM -0700, Junio C Hamano wrote: > Very nice. Thank you. > True. But we can rename it to diff_file_filespec_blob() and > that would perfectly well describe what it does. Will do so > when applying if it is Ok to you. Yes, that is a much better name (assuming s/file/free). Please do change it. > > - The hash_chars() should arguably be tied into > > diffcore_populate_filespec, which should have more of a "what > > Both good points, but I agree with you that it is wise to do > that with a follow-up patch. I think I will leave it, unless you are excited about the change. I feel like there is a high chance of introducing some bug, and the benefit is purely stylistic at this point (i.e., the diff code isn't really changing much at this point, so I think it should just be left alone). -Peff - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
