On Fri, May 06, 2022 at 09:14:07PM -0700, Elijah Newren wrote: > > That commit talks about "trees with duplicate entries". Does it > > mean a bad history where a tree object has two or more entries under > > the same name? > > Yes. > > > We should of course be catching these things at fsck > > time and rejecting at network transfer time, but I agree it is not a > > good excuse for us to segfault. We should diagnose it as a broken > > tree object and actively refuse to proceed by calling die(). Elijah would be able to comment more authoritatively than I could about whether or not these are easily detect-able. If they are, then I think it'd be worth doing so and calling die(). But they may be tricker, I don't know. Thanks, Taylor
