On Fri, May 6, 2022 at 9:30 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Alex Riesen <alexander.riesen@xxxxxxxxxxx> writes: > > > Taylor Blau, Fri, May 06, 2022 05:31:12 +0200: > > >> t4058.16, which blames back to ac14de13b2 (t4058: explore duplicate tree > > That commit talks about "trees with duplicate entries". Does it > mean a bad history where a tree object has two or more entries under > the same name? Yes. > We should of course be catching these things at fsck > time and rejecting at network transfer time, but I agree it is not a > good excuse for us to segfault. We should diagnose it as a broken > tree object and actively refuse to proceed by calling die().