On Tue, Apr 26, 2022 at 12:48 PM Derrick Stolee <derrickstolee@xxxxxxxxxx> wrote: > These points make sense. It would be worth taking our time and > doing some refactoring in advance of this functional change. Problem with taking our time or making it a bigger change is that it is currently broken in the last maint versions so it would be ideal to backport quickly there as a "regression". > I wonder how we could test a multi-user scenario. The tests I > added in e47363e5a (t0033: add tests for safe.directory, 2022-04-13) > purposefully avoid the user-id functionality. It would need to be a CI only test (where passwordless sudo is allowed) > I imagine that something else could be added here to help Windows > users who have elevated to administrator privileges. It will use a > completely different mechanism, though, if needed at all. We can > delay that for now. Note this function is *NIX only, there is another one for Windows where a similar fix (if needed) could be implemented Carlo
