On Tue, Apr 26, 2022 at 12:56 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > How much do we really want to trust SUDO_UID or DOSA_UID are telling > the truth, though? IMHO since we are only trusting this if the EUID is root it would require that the root account was compromised already or running in a tampered environment. for the absolutely paranoid we could trace back the process tree to make sure the current session was indeed created by that tool, but if we are going that way I think that trusting the ownership of the pty as was proposed[1] originally would be simpler and is indeed how other tools (like who) deal with that problem. The advantage of trusting these variables is that we can keep the more common case simpler and avoid the reported regression. Carlo [1] https://lore.kernel.org/git/20220425084003.nf267feurpqyvmsd@xxxxxxxxxxxxxx/
