On Sat, Apr 23, 2022 at 3:59 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > But if we cannot unify the way the installation is done for macOS > and Linux that way, I do not think renaming $LINUX_P4_VERSION to > another name is worth doing (notice that the point of the above > exercise was to abstract these into just two variables, VERSION and > ARCH). BTW, I was intentionally holding those changes for the same reason; if renaming the variable causes any pain (my guess was that it will be unlikely since the code got moved already at that point, and so renaming it at the same time would be unlikely to cause further conflicts) then it shouldn't be done now (or maybe ever). and those changes should only be done after all the refactoring going on now is gone, and only if discussed first with a lengthy period of RFC to make sure we get it right and go quickly. Of course, the final version of it will be unlikely to NOT have a single function that does the right thing based on those two variables and those patches were ever going to be sent as RFC. Carlo
