Re: [PATCH] fixup! CI: move p4 and git-lfs variables to ci/install-dependencies.sh

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, Apr 23, 2022 at 3:59 PM Junio C Hamano <gitster@xxxxxxxxx> wrote:
>
> If p4 and p4d were the only files that we grabbed for macOS, then
> what I wanted to suggest in the previous message would have worked,

true, but it can still work by making them both use the same version
(which would be likely a CI variable) and pull the three files from
that directory (which was my end objective as shown) in :

  https://github.com/carenas/git/commit/4fd79fa1770bc9e8e57074dbac4e44de173aeb75

> By the way, I spelunked https://filehost.perforce.com/perforce/ from
> a browser to see how the files are layed out over there, not cdist2.
> I am guessing that "filehost" is the name they want end-users like us
> to use when downloading what they distribute?

I presume that was the URL they were using when this code was written,
FWIW brew uses cdist2, and that is what I get after going to their
website at the end after clicking through their download forms so I
assume it is less likely to break as well.

agree though that renaming the variable could be avoided but it looks
nicer as an intermediate state, and we might even keep it if having
two different versions is preferred :

  https://github.com/carenas/git/commit/b6699fa3f082ef6d0e8c32718ce5142612003de8

Carlo



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux