On April 21, 2022 6:39 PM, Alyssa Ross wrote: >> I think a patch to do that would be worth having/reviewing (hint >> hint!). As always the real work is updating docs, running the tests >> etc., digging up ML discussions to see if there's been any past >> arguments for/against it etc. >> >> In this case the code change itself should be trivial (I honestly >> didn't look this time, but really, it's a config default...). So this >> seems like a perfect task for someone not too familiar with Git's >> codebase, but still interested in contributing :) > >I thought I'd have a go at a patch, but I wasn't able to get the tests >running: > > prove ./t9001-send-email.sh > ./t9001-send-email.sh .. Dubious, test returned 1 (wstat 256, 0x100) > Failed 15/188 subtests > (less 1 skipped subtest: 172 okay) > > Test Summary Report > ------------------- > ./t9001-send-email.sh (Wstat: 256 Tests: 188 Failed: 15) > Failed tests: 27, 51, 78-84, 123, 147-150, 185 > Non-zero exit status: 1 > Files=1, Tests=188, 17 wallclock secs ( 0.06 usr 0.01 sys + 11.66 cusr 5.37 csys = >17.10 CPU) > Result: FAIL > >I had a look at the tests to try to guess what was wrong, but I didn't come up with >anything. Any ideas? When I run make test, every other test is fine, it's just the >send-email tests that are problematic. I have the same issue on NonStop. Not sure why, other than our sendmail is massively broken. --Randall
