On Thu, Apr 21, 2022 at 6:55 PM Carlo Marcelo Arenas Belón <carenas@xxxxxxxxx> wrote: > Using brew to install perforce has several documented[1,2,3,4] edge > cases that make it fail periodically, so if problems were found while > installing it, just continue without it. > > This means that until the problem is solved all perforce tests will be > skipped in macOS, but they are still most likely covered by the other > unaffected runs and will be covered again once the issue solves itself. > > 1 0eb3671ed96 (ci(osx): use new location of the `perforce` cask, 2019-10-23) > 2 5ed9fc3fc86 (ci: prevent `perforce` from being quarantined, 2020-02-27) > 3 3831132ace6 (ci/install-depends: attempt to fix "brew cask" stuff, 2021-01-14) > 4 https://lore.kernel.org/git/cover-0.2-00000000000-20220421T124225Z-avarab@xxxxxxxxx/ > --- > This is based on master and can merge upwards except with seen where it > conflicts with the recently added ab/ci-osx-loosen-package-requirement > which it is meant to replace. > > A successful sample run when merged with master available in : > > https://github.com/carenas/git/actions/runs/2204519374 > > diff --git a/ci/install-dependencies.sh b/ci/install-dependencies.sh > @@ -43,7 +43,7 @@ macos-latest) > - brew install homebrew/cask/perforce > + brew install homebrew/cask/perforce || true You do get a vaguely alarming error message[1] with the solution implemented by this patch: ci/install-dependencies.sh: line 81: type: p4d: not found However, that's an unrelated and existing minor mistake (outside of the scope of this fix, probably). It should be using `command -v` rather than `type` in the couple conditionals at the bottom of the script. [1]: https://github.com/carenas/git/runs/6119943232?check_suite_focus=true#step:3:116
