On Wed, Mar 30 2022, Han Xin wrote: > On Tue, Mar 29, 2022 at 3:56 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: >> >> +/** >> + * Common steps for loose object writers to end writing loose objects: >> + * >> + * - End the compression of zlib stream. >> + * - Get the calculated oid to "oid". >> + * - fsync() and close() the "fd" > > Since we removed close_loose_object() from end_loose_object_common() , I > think this comment should also be removed. You're right. I adjusted it for the "parano_oid" in this v12, but managed to miss that somehow. Will submit a re-roll with those changes, but will wait a bit more to see if there's any other comments on this v12 first. Thanks!
