On Tue, Mar 29, 2022 at 3:56 PM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > +/** > + * Common steps for loose object writers to end writing loose objects: > + * > + * - End the compression of zlib stream. > + * - Get the calculated oid to "oid". > + * - fsync() and close() the "fd" Since we removed close_loose_object() from end_loose_object_common() , I think this comment should also be removed. Thanks. -Han Xin > + */ > +static int end_loose_object_common(git_hash_ctx *c, git_zstream *stream, > + struct object_id *oid) > +{ > + int ret; > + > + ret = git_deflate_end_gently(stream); > + if (ret != Z_OK) > + return ret; > + the_hash_algo->final_oid_fn(oid, c); > + > + return Z_OK; > +} > +