On 3/25/2022 2:27 PM, Matthieu Moy wrote:
> I couldn't understand what exactly the option was supposed to do. If I
> understand correctly, it should launch another window to show the git
> program output, but I don't know which window actually (xterm?
> x-terminal-emulator? a terminal program that isn't installed on my system?).
In VS Code settings, it seems to be x-terminal-emulator.
On 3/25/2022 8:01 PM, Derrick Stolee <derrickstolee@xxxxxxxxxx> wrote :
> >> - "externalConsole": true,
> >> + "externalConsole": false,
> I'd actually remove the line completely, to mean "let VSCode decide what to do", i.e. either VSCode's default, or the user's configuration ("launch" section in settings.json, see e.g. https://code.visualstudio.com/docs/getstarted/settings ). If some user has a > non-broken externalConsole: true VSCode and likes this behavior, then the best place to configure it is in a user-wide config file IHMO.
>
> I confirmed that deleting the line works just fine.
Yes, we agree with both of you, remove the line completly is better
because it let the user choices his preferences.
And it also work for us.
> Reported-by: Jonathan Bressat <git.jonathan.bressat@xxxxxxxxx>
> Reported-by: Cogoni Guillaume <cogoni.guillaume@xxxxxxxxx>
> Helped-by: Matthieu Moy <Matthieu.Moy@xxxxxxxxxxxxx>
> Signed-off-by: Derrick Stolee <derrickstolee@xxxxxxxxxx>
> ---
> contrib/vscode/init.sh | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/contrib/vscode/init.sh b/contrib/vscode/init.sh
> index 27de94994b5..f139fd86444 100755
> --- a/contrib/vscode/init.sh
> +++ b/contrib/vscode/init.sh
> @@ -271,7 +271,6 @@ cat >.vscode/launch.json.new <<EOF ||
> "stopAtEntry": false,
> "cwd": "\${workspaceFolder}",
> "environment": [],
> - "externalConsole": true,
> "MIMode": "gdb",
> "miDebuggerPath": "$GDBPATH",
> "setupCommands": [
> --
> 2.35.1.138.gfc5de29e9e6
>
>
https://code.visualstudio.com/docs/editor/debugging
https://code.visualstudio.com/docs/getstarted/settings
Maybe, It would be nice to add these two links in
contrib/vscode/readme.md, this may be relevant to
help new users that want to use vscode debugger. And add some explanations
like "How to use it".
Except that, your patch sounds good for us.
Thanks,
Guillaume and Jonathan.
