On 3/25/2022 2:27 PM, Matthieu Moy wrote:
> On 3/25/22 14:19, Derrick Stolee wrote:
>
>> Jonathan and Guillame reported that flipping this setting to "false"
>> allows the VS Code debugger to work with Git. I verified that the
>> debugger did not work by default but now does with this change.
>
> FYI, I got the same problem, and I can reproduce the issue on a hello world program, so "externalConsole": true, is broken at least for me regardless of the Git codebase.
>
> I couldn't understand what exactly the option was supposed to do. If I understand correctly, it should launch another window to show the git program output, but I don't know which window actually (xterm? x-terminal-emulator? a terminal program that isn't installed on my system?).
>
>> contrib/vscode/init.sh | 2 +-
>> t/test-lib-functions.sh | 34 ----------------------------------
>
> I guess the test-lib-functions.sh part is a leftover from another work?
Whoops! Yes I was in the wrong worktree.
>> - "externalConsole": true,
>> + "externalConsole": false,
> I'd actually remove the line completely, to mean "let VSCode decide what to do", i.e. either VSCode's default, or the user's configuration ("launch" section in settings.json, see e.g. https://code.visualstudio.com/docs/getstarted/settings ). If some user has a non-broken externalConsole: true VSCode and likes this behavior, then the best place to configure it is in a user-wide config file IHMO.
I confirmed that deleting the line works just fine.
Here's a better patch without the bogus extra changes.
--- >8 ---
