Hi Phillip, On Wed, 9 Mar 2022, Phillip Wood wrote: > From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx> > > Thanks to Ramsay and Ævar for their comments on V1. > Changes since V1: > * Patch 1 > - use an enum for save_term()'s flags (suggested by Ævar) > - fixed argument order in the windows code (thanks to Ramsay) > * Patch 2 > - fixed a typo in a comment (thanks to Ramsay) > * Patch 4 > - stopped duplicating the strings returned by gettext() (suggested by > Ævar) > - reworked error message handling in the signal handler to add an > "error: " prefix (suggested by Ævar) > - tweaked the background resume error message While I did not ask for any of these changes, they look good to me. I had a look over the range-diff and found it reasonable. Onwards to a bright built-in `add -p` future! Thanks, Dscho
