Junio C Hamano <gitster@xxxxxxxxx> writes: > Jonathan Tan <jonathantanmy@xxxxxxxxxx> writes: > >> The check_ names still aren't changed (as I suggested in [1]) but >> perhaps it's fine to leave it. It doesn't seem to bother the other >> reviewers, and changing it would slightly disrupt the review in that >> there will be extra changes in the range-diff. > > At least, please do not count my not mentioning it as such a vote. > I didn't mention it because I saw you did. Oh! Sorry, I intended to do this - I missed this and another suggestion that you made re: test assertions [1]. Will incorporate this into the next round. [1] 20220304234622.647776-1-jonathantanmy@xxxxxxxxxx
