Glen Choo <chooglen@xxxxxxxxxx> writes:
> +check_sub () {
> + NEW_HEAD=$1 &&
> + cat >$pwd/expect.err.sub <<-EOF
> + Fetching submodule submodule
> + From $pwd/submodule
> + OLD_HEAD..$NEW_HEAD sub -> origin/sub
> + EOF
> +}
> +
> +check_deep () {
> + NEW_HEAD=$1 &&
> + cat >$pwd/expect.err.deep <<-EOF
> + Fetching submodule submodule/subdir/deepsubmodule
> + From $pwd/deepsubmodule
> + OLD_HEAD..$NEW_HEAD deep -> origin/deep
> + EOF
> +}
> +
> +check_super () {
> + NEW_HEAD=$1 &&
> + cat >$pwd/expect.err.super <<-EOF
> + From $pwd/.
> + OLD_HEAD..$NEW_HEAD super -> origin/super
> + EOF
> +}
The check_ names still aren't changed (as I suggested in [1]) but
perhaps it's fine to leave it. It doesn't seem to bother the other
reviewers, and changing it would slightly disrupt the review in that
there will be extra changes in the range-diff.
[1] https://lore.kernel.org/git/20220224230523.2877129-1-jonathantanmy@xxxxxxxxxx/
