On 3/2/2022 12:10 PM, Ævar Arnfjörð Bjarmason wrote: > Fix various memory leaks in "git index-pack", due to how tightly > coupled this command is with the revision walking this doesn't make > any new tests pass, but e.g. this now passes, and had several failures before: > > ./t5300-pack-object.sh --run=1-2,4,6-27,30-42 Do you mean that these tests now pass under leak check? > it is a bit odd that we'll free "opts.anomaly", since the "opts" is a s/it/It/ > "struct pack_idx_option" declared in pack.h. In pack-write.c there's a > reset_pack_idx_option(), but it only wipes the contents, but doesn't > free() anything. > > Doing this here in cmd_index_pack() is correct because while the > struct is declared in pack.h, this code in builtin/index-pack.c (in > read_v2_anomalous_offsets()) is what allocates the "opts.anomaly", so > we should also free it here. Makes sense. Code diff looks good. Thanks, -Stolee
