On 3/1/2022 7:57 PM, Taylor Blau wrote: > Here is a reroll of my series to implement "cruft packs", a pack which > stores accumulated unreachable objects, along with a new ".mtimes" file > which tracks each object's last known modification time. > > This was on the list towards the end of 2021[1], and I have been > accumulating small changes to it locally for a couple of months now. > Major changes since last time include: > > - Clearer documentation and commit message(s) to better illustrate how > the feature works and is supposed to be used. > > - Some minor documentation updates to pack-format.txt, which make some > ambiguous details more explicit. > > - Minor code movement / tweaks to make things easier to read, ensure > that functions aren't introduced in patches before they are used / > etc. > > - Moved the new test script to t5328 (instead of t5327, which happens > to be taken up by a new MIDX bitmap-related test), and purged it of > all "rm -fr .git/logs" (replacing them with "git reflog --expire > --all --expire=all" instead). > > - A new test which fixes a bug where loose objects which have copies > that appear in a cruft pack would not get accumulated when doing a > `--geometric` repack. > > For convenience, a range-diff is below. Thanks in advance for taking > another look! It had been a while since my last read, so I read the patches in full one more time. I found a couple nitpicks, but otherwise everything is looking good. Thanks, -Stolee
