Glen Choo <chooglen@xxxxxxxxxx> writes: > I think this patch could be squashed into the previous one, let me know > if this is a good idea. For what it's worth, as a reviewer, I appreciated this patch being its own. It made it easier to review. It's unfortunate that the created diff has fetch_task_create() deleted and readded, but showing it with --anchored=" memset(task, 0, sizeof(*task));" does make it easier to see. (The space before memset is a tab.) > + cleanup: > + fetch_task_release(task); > + free(task); > + return NULL; > +} No space between the left margin and "cleanup". Otherwise, up to and including this patch looks good.
