Glen Choo <chooglen@xxxxxxxxxx> writes: > @@ -1389,6 +1389,7 @@ struct fetch_task { > struct repository *repo; > const struct submodule *sub; > unsigned free_sub : 1; /* Do we need to free the submodule? */ > + const char *default_argv; > > struct oid_array *commits; /* Ensure these commits are fetched */ > }; I preferred the other way of passing default_argv in parallel, because it is only used for the interaction in between get_fetch_task() and get_next_submodule(), but I don't feel too strongly about this. In any case, up to and including this patch looks good.