Hi Elijah, On Mon, 21 Feb 2022, Elijah Newren wrote: > On Mon, Feb 21, 2022 at 1:13 AM Johannes Schindelin > <Johannes.Schindelin@xxxxxx> wrote: > > > > Hi Elijah, > > > > On Thu, 3 Feb 2022, Elijah Newren wrote: > > > > > On Thu, Feb 3, 2022 at 8:24 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > > > > > > > On Thu, Feb 03 2022, Elijah Newren wrote: > > > > > > > > > Man, what a can of worms this all is. Maybe I really should just drop > > > > > patches 5, 6, and 8 for now... > > > > > > > > Yeah, I really think it's worth it to just sprinkle a tiny bit of > > > > if/else (or a macro) here and print to stderr inline or not. We can make > > > > some use of some usage.c when there's good reason to do so, but this bit > > > > just seems like a needless digression. > > > > > > > > I hope all of this has helped somewhat ... > > > > > > Absolutely; thanks for reviewing! These parts may just end up in me > > > dropping some patches for now (since they're not actually being used > > > anyway), but I think it's all good feedback. > > > > So we dropped some useful patches future-proofing `merge-tree` for the > > sake of appeasing a refactoring with no immediately obvious benefit? I > > really don't like that direction. > > Even before any of Ævar's comments, I had already noted on my cover > letter[1] that "to be honest, patches 5, 6, & 8 may be less relevant > since we're now including these messages on stdout anyway" -- so I was > already wondering if I should defer them to some future series. Ah, that was not clear to me. In that case, I retract my objections. Thanks for clarifying, Dscho
