On Mon, Feb 21, 2022 at 1:13 AM Johannes Schindelin <Johannes.Schindelin@xxxxxx> wrote: > > Hi Elijah, > > On Thu, 3 Feb 2022, Elijah Newren wrote: > > > On Thu, Feb 3, 2022 at 8:24 AM Ævar Arnfjörð Bjarmason <avarab@xxxxxxxxx> wrote: > > > > > > On Thu, Feb 03 2022, Elijah Newren wrote: > > > > > > > Man, what a can of worms this all is. Maybe I really should just drop > > > > patches 5, 6, and 8 for now... > > > > > > Yeah, I really think it's worth it to just sprinkle a tiny bit of > > > if/else (or a macro) here and print to stderr inline or not. We can make > > > some use of some usage.c when there's good reason to do so, but this bit > > > just seems like a needless digression. > > > > > > I hope all of this has helped somewhat ... > > > > Absolutely; thanks for reviewing! These parts may just end up in me > > dropping some patches for now (since they're not actually being used > > anyway), but I think it's all good feedback. > > So we dropped some useful patches future-proofing `merge-tree` for the > sake of appeasing a refactoring with no immediately obvious benefit? I > really don't like that direction. Even before any of Ævar's comments, I had already noted on my cover letter[1] that "to be honest, patches 5, 6, & 8 may be less relevant since we're now including these messages on stdout anyway" -- so I was already wondering if I should defer them to some future series. Then when Ævar reviewed the series, he noted (1) that I lacked tests of these changes (which is true, because nothing uses them, and I can't easily add a test as I have no current usecase in mind), and (2) these patches would print a "warning: " prefix when printing to stdout but not print such a prefix otherwise, which felt inconsistent. Those seemed to reinforce the comment I had already made that these changes were unused in my series and maybe should be separated. I still like the general idea behind the future proofing you did here, so maybe I was just being lazy, but between those factors I decided that punting until later made sense. [1] https://lore.kernel.org/git/pull.1122.v3.git.1643787281.gitgitgadget@xxxxxxxxx/
