Johannes Schindelin <Johannes.Schindelin@xxxxxx> writes: > The reason we used "case" is that this has always been a builtin > (has to be, because it changes workflow). > > Therefore I am somewhat uneasy that the patch went in so easily, It didn't yet. > especially given a message that flies in the face of our endeavours > to make git less dependent on any given shell (as long as it is not > broken to begin with). "test" is not actually a shell dependency since it is available as an external when not available as builtin. And if you really want to prefer "case" over "test" because the latter is not a built-in in a small number of shells, then it should be done consistently everywhere and not just in code I touch. -- David Kastrup - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html