"David Symonds" <dsymonds@xxxxxxxxx> writes: > On 24/09/2007, David Kastrup <dak@xxxxxxx> wrote: >> Mike Hommey <mh@xxxxxxxxxxxx> writes: >> >> > On Sun, Sep 23, 2007 at 10:42:08PM +0200, David Kastrup wrote: >> >> -while case $# in 0) break ;; esac >> >> +while test $# != 0 >> > >> > Wouldn't -ne be better ? >> >> Why? > > Because -ne does a numeric comparison, != does a string comparison, > and it's a numeric comparison happening, semantically speaking. I don't see the point in converting $# and 0 into numbers before comparing them. "!=" is quite more readable, and the old code also compared the strings. -- David Kastrup - To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
