Re: [PATCH v6 0/3] completion: sparse-checkout updates

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Elijah Newren <newren@xxxxxxxxx> writes:

> Ævar had a good comment about code coverage on Windows that we might
> want to address first[1].  (Namely, splitting one test into two -- one
> that tests a path with backslashes that can be skipped on windows, and
> a separate test that checks paths with spaces, tabs, and non-ascii
> that can be run on all platforms.)

According to the lazy-prereq definition for FUNNYNAMES, we seem to
skip tab-embedded names on windows, so it may not be used on all
platforms, but such a detail aside...

I do not get why funny letters should matter and need to be tested
specially in the first place, to be honest, but because we have with
FUNNYNAMES prereq already, hiding some tests behind it would be a
good idea regardless.

> But other than that, yeah, this should be ready for 'next'.
>
> [1] https://lore.kernel.org/git/220204.86h79f45nf.gmgdl@xxxxxxxxxxxxxxxxxxx/

Thanks.




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux