On Fri, Feb 4, 2022 at 9:04 AM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Elijah Newren <newren@xxxxxxxxx> writes: > > >> Changes since V5 > >> ================ > >> > >> * Fix incorrect conditional that was causing failure of non-cone mode test > >> (and causing 'seen' CI to fail). > >> * Remove __git_comp_directories indentation changes between the second and > >> third commits. > > > > This round looks good to me: > > > > Reviewed-by: Elijah Newren <newren@xxxxxxxxx> > > > > Nice work! > > Thanks, both. Will queue. Let's mark it to be merged down to > 'next' soonish. Ævar had a good comment about code coverage on Windows that we might want to address first[1]. (Namely, splitting one test into two -- one that tests a path with backslashes that can be skipped on windows, and a separate test that checks paths with spaces, tabs, and non-ascii that can be run on all platforms.) But other than that, yeah, this should be ready for 'next'. [1] https://lore.kernel.org/git/220204.86h79f45nf.gmgdl@xxxxxxxxxxxxxxxxxxx/
