On Wed, Jan 12, 2022 at 8:47 AM Joel Holdsworth <jholdsworth@xxxxxxxxxx> wrote: > This patch improves consistency across git-p4 by ensuring all command > separated arguments to function invocations, tuples and lists are > separated by commas with a single space following. > > Signed-off-by: Joel Holdsworth <jholdsworth@xxxxxxxxxx> > --- > diff --git a/git-p4.py b/git-p4.py > @@ -303,7 +303,7 @@ def run_hook_command(cmd, param): > - (root,ext) = os.path.splitext(cmd) > + root, ext = os.path.splitext(cmd) Someone who doesn't code in Python regularly might wonder if the removal of parentheses on the left side of the assignment brings some sort of semantic change with it. Perhaps the removal deserves mention in the commit message? Not necessarily worth a reroll.
