Am 28.12.21 um 00:23 schrieb Jean-Noël Avila via GitGitGadget:
> From: =?UTF-8?q?Jean-No=C3=ABl=20Avila?= <jn.avila@xxxxxxx>
>
> Signed-off-by: Jean-Noël Avila <jn.avila@xxxxxxx>
Two questions:
- Is "%s requires %s" already used elsewhere or is it a new translatable
string? The commit message should clarify the choice.
- Do translators know that the two %s will be substituted with options
(mostly)?
> --- a/fetch-pack.c
> +++ b/fetch-pack.c
> @@ -297,7 +297,7 @@ static int find_common(struct fetch_negotiator *negotiator,
> struct packet_reader reader;
>
> if (args->stateless_rpc && multi_ack == 1)
> - die(_("--stateless-rpc requires multi_ack_detailed"));
> + die(_("%s requires %s"), "--stateless-rpc", "multi_ack_detailed");
Here, the second %s is not an option. I hope that does not invalidate
any translation of the string.
-- Hannes
