RE: [PATCH 0/6] Transition git-p4.py to support Python 3 only

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > What unit tests are these? I am happy to test with them.
> 
>     cd t
>     make T=t98* -j$(nproc)

Awesome! Just ran the tests. We got a clean sweep.

With one proviso:

When running the current upstream master git-p4 version, there are errors if /usr/bin/python is not present.

lib-git-p4.sh checks for the presence of python with "test_have_prereq PYTHON" - but if I only have /usr/bin/python3 installed, the prerequisite check passes, but git-p4.py itself fails because the shebang points at python not python3.

On Debian installing the package "python-is-python3" fixes the issue.

Perhaps it might help to have something like "test_have_prereq PYTHON3".

Regardless, if python3 is installed, this patch-set passes the tests just fine.

Joel




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux